martin-g commented on code in PR #3626:
URL: https://github.com/apache/avro/pull/3626#discussion_r2715591110
##########
doc/assets/scss/_styles_project.scss:
##########
@@ -33,3 +33,36 @@
.navbar-brand {
font-family: "PT Mono", monospace;
}
+
+@media (max-width: 996px) {
+
+ footer .row {
+ display: flex;
+ flex-direction: column;
+ align-items: center;
+ text-align: center;
Review Comment:
```suggestion
```
This one seems redundant. The one at line 49 will override it anyway.
##########
doc/assets/scss/_styles_project.scss:
##########
@@ -33,3 +33,36 @@
.navbar-brand {
font-family: "PT Mono", monospace;
}
+
+@media (max-width: 996px) {
Review Comment:
Why 996 ?
https://getbootstrap.com/docs/5.0/layout/breakpoints/ uses 992
##########
doc/assets/scss/_styles_project.scss:
##########
@@ -33,3 +33,36 @@
.navbar-brand {
font-family: "PT Mono", monospace;
}
+
+@media (max-width: 996px) {
+
+ footer .row {
+ display: flex;
+ flex-direction: column;
+ align-items: center;
+ text-align: center;
+ }
+
+ footer [class^="col-"] {
+ width: 100% !important;
+ max-width: 100% !important;
+ text-align: center !important;
+ margin-bottom: 1.25rem;
+ }
+
+ footer ul.list-inline {
+ display: flex;
+ justify-content: center;
+ flex-wrap: wrap;
+ }
+
+ footer ul.list-inline li {
+ margin: 0.4rem;
+ }
+
+ footer img {
+ margin-left: auto;
+ margin-right: auto;
+ display: block;
+ }
+}
Review Comment:
```suggestion
}
```
##########
doc/assets/scss/_styles_project.scss:
##########
@@ -33,3 +33,36 @@
.navbar-brand {
font-family: "PT Mono", monospace;
}
+
+@media (max-width: 996px) {
+
+ footer .row {
+ display: flex;
+ flex-direction: column;
+ align-items: center;
+ text-align: center;
+ }
+
+ footer [class^="col-"] {
+ width: 100% !important;
Review Comment:
`!important` is usually not recommended. Did you try without it ? E.g. with
more concrete selector.
##########
doc/assets/scss/_styles_project.scss:
##########
@@ -33,3 +33,36 @@
.navbar-brand {
font-family: "PT Mono", monospace;
}
+
+@media (max-width: 996px) {
+
+ footer .row {
+ display: flex;
+ flex-direction: column;
+ align-items: center;
+ text-align: center;
+ }
+
+ footer [class^="col-"] {
+ width: 100% !important;
+ max-width: 100% !important;
+ text-align: center !important;
+ margin-bottom: 1.25rem;
+ }
+
+ footer ul.list-inline {
+ display: flex;
+ justify-content: center;
+ flex-wrap: wrap;
+ }
+
+ footer ul.list-inline li {
+ margin: 0.4rem;
+ }
+
+ footer img {
Review Comment:
Is this needed ?
`<img>` is an inline element, so the `text-align: center` from line 49
should be enough.
##########
doc/assets/scss/_styles_project.scss:
##########
@@ -33,3 +33,36 @@
.navbar-brand {
font-family: "PT Mono", monospace;
}
+
+@media (max-width: 996px) {
+
+ footer .row {
+ display: flex;
+ flex-direction: column;
+ align-items: center;
+ text-align: center;
+ }
+
+ footer [class^="col-"] {
Review Comment:
This will match only if "col-..." is the first item in `class="..."`, e.g.
`class="col-3"`, but it won't match for `class="another col-3"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
