[ 
https://issues.apache.org/jira/browse/AVRO-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18053559#comment-18053559
 ] 

ASF subversion and git services commented on AVRO-4221:
-------------------------------------------------------

Commit db5502351a76d311f9f51ea761298a25fc2637a0 in avro's branch 
refs/heads/branch-1.12 from Stephan Lachnit
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=db5502351a ]

AVRO-4221: [C++] Allow using symbol visibility annotations also on non-Windows 
platforms (#3602)

In GCC and clang the symbol visibility behavior of MSVC can be mirror using 
`-fvisibility=hidden`.
This allows to more easily test that symbol visbility annotations work 
correctly and can potentially lead to smaller binaries.
The default behavior on non-Windows platforms is not changed with this commit.

See also https://gcc.gnu.org/wiki/Visibility

Also fixes a tiny mistake where the _WIN32 macro was used to silence a MSVC 
warning where the _MSC_VER macro should have been used instead.

> [C++] Allow using symbol visibility annotations on non-Windows platforms
> ------------------------------------------------------------------------
>
>                 Key: AVRO-4221
>                 URL: https://issues.apache.org/jira/browse/AVRO-4221
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: c++
>    Affects Versions: 1.12.1, 1.13.0
>            Reporter: Stephan Lachnit
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> In GCC and clang the symbol visibility behavior of MSVC can be mirror using 
> `-fvisibility=hidden`. This allows to more easily test that symbol visbility 
> annotations work correctly and can potentially lead to smaller binaries.
>  
> Currently this is not possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to