Kriskras99 commented on code in PR #423:
URL: https://github.com/apache/avro-rs/pull/423#discussion_r2718781063
##########
avro/src/schema/record/schema.rs:
##########
@@ -90,11 +90,14 @@ mod tests {
let record_schema = RecordSchema::builder()
.name(name.clone())
- .aliases(Some(vec!["alias_1".into()]))
+ .aliases(Some(vec!["alias_1".try_into().expect("Alias is valid")]))
Review Comment:
Implementing `FromStr` is a good idea, but I still want to get rid of
`From`. It signals to the user that this is an infallible conversion, while it
really isn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
