Kriskras99 commented on issue #424:
URL: https://github.com/apache/avro-rs/issues/424#issuecomment-3789618507
# Decisions to make before 0.22
- [ ] #423
- [ ] #419
- This would be a breaking change, as currently `RecordBuilder::name` will
always work (and then fail in `build()`) while this change would make it return
a result
- [ ] #400
- It would be good to change the trait to take a `HashSet<Name>` instead
of a `HashMap<Name, Schema>`. It would be more efficient by reducing
unnecessary clones
- I expect that this wouldn't break a lot of code, as most usage will be
via the `AvroSchema` trait and most implementations via the `AvroSchema` derive
- [ ] #383
- `Value::resolve(reader_schema: &Schema)` should become
`Value::resolve(writer_schema: &Schema, reader_schema: &Schema)`
- [ ] #368
- To fix this issue the `Schema` type would need to be changed
- [ ] #365
- To properly support enums in `to_value` it should take a `writer_schema:
&Schema` and then use `SchemaAwareWriteSerializer`
- To properly support enums in `from_value` it should also take a
`writer_schema: &Schema` and we would need a `SchemaAwareReadDeserializer`
(#237) (We don't actually need to implement this yet, just change `from_value`
to take the schema and ignore it)
- [ ] For the Serde improvements (#361) I would like to move the `bytes`
module to the `serde` module.
- This won't need to be a breaking change as we can just keep `bytes` as
deprecated
- [ ] Do we have any deprecated items that we want to remove now?
I would also like to update the Serde documentation before this release. I
think enum support will go to the next release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
