martin-g commented on code in PR #439:
URL: https://github.com/apache/avro-rs/pull/439#discussion_r2727349780


##########
avro/src/writer.rs:
##########
@@ -643,7 +643,18 @@ where
             self.header_written = true;
         }
 
-        bytes_written += write_avro_datum_ref(&self.schema, data, writer)?;
+        // Use the resolved schema names from the inner 
GenericSingleObjectWriter
+        // to properly resolve Schema::Ref during serialization
+        let names_ref = self
+            .inner
+            .resolved
+            .get_names()
+            .iter()

Review Comment:
   Why do we need to iterate + map + collect ?
   Can't we just use the result of `get_names()` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to