mattiabasone commented on code in PR #3634:
URL: https://github.com/apache/avro/pull/3634#discussion_r2729432689
##########
lang/php/lib/AvroDebug.php:
##########
@@ -59,37 +59,34 @@ public static function debug($format, $args, $debug_level =
self::DEBUG1)
* or more verbose than than the current debug level
* and false otherwise.
*/
- public static function isDebug(int $debug_level = self::DEBUG1): bool
+ public static function isDebug(int $debugLevel = self::DEBUG1): bool
{
- return self::DEBUG_LEVEL >= $debug_level;
+ return self::DEBUG_LEVEL >= $debugLevel;
}
/**
- * @param string $str
Review Comment:
This one and the following ones, they have been removed because they don't
bring any value right now and the type is already specified in the function
signature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
