apupier commented on PR #3685: URL: https://github.com/apache/avro/pull/3685#issuecomment-4023537149
> > I do not think that we can use a matrix easily as the minimal Java version to do the compilation is JDK 21 but tests are launched with several JDKs versions. it is launched with different Maven execution directly defined in the pom.xml. Each version si picked from the toolchains.xml whcih is configured by the > > OK! I'll leave it to you. I haven't touched the Java SDK for a long time and obviously I have forgotten how it works. Please revert whatever is needed. in fact, there are 2 ways of doing it. Either set the minimal version to Java 17, use a matrix job and keep a single execution. Or rely on toolchains. it is a bit more advanced, I think it will save time on Ci and it forces to have test splayed locally with all jdk by default. The downside is that it is more complicated to setup and seems that even committers on the project do not remember it. So I think I will remove the different executions and reliance on the toolchain. (especially when I see that the jobs are already green now, it is just that we are playing the same tests several times with same JDKs and we cna go a bit faster) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
