KalleOlaviNiemitalo commented on code in PR #3744:
URL: https://github.com/apache/avro/pull/3744#discussion_r3147204038
##########
lang/csharp/src/apache/test/AvroDecimalTest.cs:
##########
@@ -23,17 +23,18 @@ namespace Avro.test
[TestFixture]
class AvroDecimalTest
{
- [TestCase(1)]
- [TestCase(1000)]
- [TestCase(10.10)]
- [TestCase(0)]
- [TestCase(0.1)]
- [TestCase(0.01)]
- [TestCase(-1)]
- [TestCase(-1000)]
- [TestCase(-10.10)]
- [TestCase(-0.1)]
- [TestCase(-0.01)]
+ //Use strings as parameters as otherwise doubles will be used
intermediately by C# and scale will be lost in this process
Review Comment:
This may make the test culture-sensitive. I suggest changing the parameters
to `string` and explicitly calling `decimal.Parse` with
`CultureInfo.InvariantCulture` within the test methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
