[
https://issues.apache.org/jira/browse/AVRO-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18079829#comment-18079829
]
ASF subversion and git services commented on AVRO-3941:
-------------------------------------------------------
Commit 4efe588629b4f60dd983604452deca79897c6e0f in avro's branch
refs/heads/branch-1.12 from RawScape
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=4efe588629 ]
AVRO-2825: [csharp] Resolve: C# Logical Types throw exception on unknown (#3727)
* AVRO-2825: [csharp] Resolve: C# Logical Types throw exception on unknown
logical type
(cherry picked from commit ad61af02da435652ba0662d34205f60fa88537cb)
* [AVRO-3941] CSharp Resolve missing namespace issue
(cherry picked from commit e5a7dedf9959687637f621bfdecbe478a5a89cc4)
* Resolve requested changes on PR 2751
(cherry picked from commit 89095295036d0dbd180fa4265205f0d666b3c0d9)
* uncomment testcase after testing
(cherry picked from commit 235d329118764005c2ace77bc7b26e472bcd5e14)
* savepoint remove local setting files
(cherry picked from commit f7b4872a347938d090193a55beba3ff2a31bcefa)
* backout chags for a different pr, adjust unit test
(cherry picked from commit 60463b5da7c885ce4e90ff9cf2d81c7682d59b0b)
* changes from code review
(cherry picked from commit 42b0fbd0a665cf409b85e329151f5b5d3e2a07e8)
* Resolve remaining feedback for AVRO-2825 and fix complex logical type parsing
* Fix CodeQL warning: Use pattern matching to assert logicalSchema type safely
* Remove accidentally tracked launchSettings.json
---------
Co-authored-by: Tom Bruns <[email protected]>
> C# implementation of avrogen throws an exception if the schema file does not
> contain a namespace
> -------------------------------------------------------------------------------------------------
>
> Key: AVRO-3941
> URL: https://issues.apache.org/jira/browse/AVRO-3941
> Project: Apache Avro
> Issue Type: Bug
> Components: compatibility, csharp
> Affects Versions: 1.11.3
> Reporter: Tom Bruns
> Priority: Major
>
> The AVRO spec does not require a namespace and the java implementation of
> avrogen successfully generates a java POJO class when the schema file does
> not have one.
> The issue is in CodeGen.cs around line 896 and is because of the use of
> CodeNamespace that requires one.
> Would it be acceptable to submit a PR that optionally adds a "default"
> namespace (ex: SchemaHadNoNamespace) if the schema file does not have one?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
