mkeskells commented on code in PR #3746:
URL: https://github.com/apache/avro/pull/3746#discussion_r3230406434
##########
lang/java/avro/src/main/java/org/apache/avro/file/DataFileStream.java:
##########
@@ -127,7 +151,7 @@ void initialize(InputStream in, byte[] magic) throws
IOException {
if (l > 0) {
do {
for (long i = 0; i < l; i++) {
- String key = vin.readString(null).toString();
+ String key = vin.readString();
Review Comment:
not related to the schema cache, but removes the allocation of the
ByteBuffer, which is disguarded immediately. This was done after the benchmark
results were published and will reduce allocations by the size of the schema
for each file parsed, for all scenarios
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
