iemejia commented on PR #3822: URL: https://github.com/apache/avro/pull/3822#issuecomment-5317408352
Thanks @prygunov — the enum-default fix is correct. I pushed some changes directly to finish it up (force-pushed, so reset your local copy): **1. Squashed your 3 commits** into one under your authorship with a proper `AVRO-4332` message (tree unchanged). **2. Added a maintainer commit fixing pre-existing breakage your PR surfaced.** The `IdlUtilsTest` class never actually ran in CI — Surefire only includes `**/Test**` (names starting with `Test`), so it's been dormant since it was added. Your new tests wouldn't have run either (not your fault — you followed the file's convention). Renaming it to `TestIdlUtils` uncovered latent bugs I fixed: - Real bug in `IdlUtils`: the `byte[]` serializer discarded its output instead of writing to the generator, so `bytes` serialized to `""`. - The `callToJson` test helper had the same discard bug. - The `validateHappyFlow*` fixtures were in the wrong package (unreachable → NPE); moved and regenerated them. - Dropped obsolete union-unwrapping and fixed the map/collection separator expectations. The `idl` module now runs 39 green tests (your 4 enum tests + 18 previously hidden). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
