svozza commented on PR #3970: URL: https://github.com/apache/avro/pull/3970#issuecomment-5413419824
> Alright, this LGTM -- I don't want to abuse your expertise 😄 but can you advise us how to write a unit test (ideally run through ./build.sh test that would raise an error before this happens again? Would you believe I did have a unit test for this originally and removed it! Haha. I will add it back. > Your thoughts on getting rid of the dependency are welcome -- if it's a risky or breaking change we can reserve it for the 1.13.0 release and keep it for the 1.12.x branch. I think it's relatively low risk and I will make sure that it doesn't have a breaking change when I do the PR. There are actually unit tests for this module but they don't run as part of the Mocha suite. I will port them to Mocha before I write any code and make sure my changes don't break them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
