Kriskras99 commented on code in PR #666:
URL: https://github.com/apache/avro-rs/pull/666#discussion_r4121555079
##########
avro/src/types.rs:
##########
@@ -562,8 +744,13 @@ impl Value {
// TODO: check precision against n
(&Value::Fixed(_n, _), &Schema::Decimal { .. }) => None,
(Value::String(s), Schema::Enum(EnumSchema { symbols, .. })) => {
+ let value_path = ValuePath::Value(self, value_path);
if !symbols.contains(s) {
- Some(format!("'{s}' is not a member of the possible
symbols"))
+ // By doing s:? we get an escaped string
+ Some(format!(
+ "{value_path}({s:?}) is not a symbol in {}",
Review Comment:
It can be, but we don't log it. It's up to the user of the library to handle
data with the needed care.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
