[
https://issues.apache.org/jira/browse/BEAM-5637?focusedWorklogId=154386&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154386
]
ASF GitHub Bot logged work on BEAM-5637:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/18 17:35
Start Date: 15/Oct/18 17:35
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #6680:
[BEAM-5637] Python support for custom dataflow worker jar
URL: https://github.com/apache/beam/pull/6680#discussion_r225253813
##########
File path: sdks/python/apache_beam/runners/portability/stager.py
##########
@@ -256,6 +256,14 @@ def stage_job_resources(self,
'The file "%s" cannot be found. Its location was specified by '
'the --sdk_location command-line option.' % sdk_path)
+ worker_options = options.view_as(WorkerOptions)
+ if hasattr(worker_options, 'dataflow_worker_jar') and \
Review comment:
Could you please use ```getattr``` rather than ```hasatter``` :
https://hynek.me/articles/hasattr/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 154386)
Time Spent: 2h 50m (was: 2h 40m)
> Python support for custom dataflow worker jar
> ---------------------------------------------
>
> Key: BEAM-5637
> URL: https://issues.apache.org/jira/browse/BEAM-5637
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Henning Rohde
> Assignee: Ruoyun Huang
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> One of the slightly subtle aspects is that we would need to ignore one of the
> staged jars for portable Python jobs. That requires a change to the Python
> boot code:
> https://github.com/apache/beam/blob/66d7c865b7267f388ee60752891a9141fad43774/sdks/python/container/boot.go#L104
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
