[ https://issues.apache.org/jira/browse/BEAM-4130?focusedWorklogId=154943&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154943 ]
ASF GitHub Bot logged work on BEAM-4130: ---------------------------------------- Author: ASF GitHub Bot Created on: 16/Oct/18 15:52 Start Date: 16/Oct/18 15:52 Worklog Time Spent: 10m Work Description: mxm commented on a change in pull request #6703: [BEAM-4130] Add tests for FlinkJobServerDriver URL: https://github.com/apache/beam/pull/6703#discussion_r225601626 ########## File path: runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobServerDriver.java ########## @@ -54,44 +55,44 @@ /** Configuration for the jobServer. */ public static class ServerConfiguration { @Option(name = "--job-host", usage = "The job server host name") - private String host = ""; + String host = "localhost"; @Option( name = "--job-port", usage = "The job service port. 0 to use a dynamic port. (Default: 8099)" ) - private int port = 8099; + int port = 8099; @Option( name = "--artifact-port", usage = "The artifact service port. 0 to use a dynamic port. (Default: 8098)" ) - private int artifactPort = 8098; + int artifactPort = 8098; @Option(name = "--artifacts-dir", usage = "The location to store staged artifact files") - private String artifactStagingPath = + String artifactStagingPath = Paths.get(System.getProperty("java.io.tmpdir"), "beam-artifact-staging").toString(); @Option( name = "--clean-artifacts-per-job", usage = "When true, remove each job's staged artifacts when it completes" ) - private Boolean cleanArtifactsPerJob = false; + boolean cleanArtifactsPerJob = false; @Option(name = "--flink-master-url", usage = "Flink master url to submit job.") - private String flinkMasterUrl = "[auto]"; Review comment: This is really a minor issue considering that FlinkJobServerDriver is not user-facing at all. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 154943) Time Spent: 13h 10m (was: 13h) > Portable Flink runner JobService entry point in a Docker container > ------------------------------------------------------------------ > > Key: BEAM-4130 > URL: https://issues.apache.org/jira/browse/BEAM-4130 > Project: Beam > Issue Type: New Feature > Components: runner-flink > Reporter: Ben Sidhom > Assignee: Maximilian Michels > Priority: Minor > Fix For: 2.7.0 > > Time Spent: 13h 10m > Remaining Estimate: 0h > > The portable Flink runner exists as a Job Service that runs somewhere. We > need a main entry point that itself spins up the job service (and artifact > staging service). The main program itself should be packaged into an uberjar > such that it can be run locally or submitted to a Flink deployment via `flink > run`. -- This message was sent by Atlassian JIRA (v7.6.3#76005)