[ 
https://issues.apache.org/jira/browse/BEAM-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652186#comment-16652186
 ] 

Valentyn Tymofieiev commented on BEAM-5315:
-------------------------------------------

Hi [~udim], thanks for upgrading the Datastore dependency. You could:

1. Make sure existing ~35 datastore unit tests pass on Python 2.
2. Modify setup.py to remove the restriction that prevents installation of 
datastore client library on Python 3: 
https://github.com/apache/beam/blob/3e7e0346492f9c70903590c50133f9f5a5acf9ee/sdks/python/setup.py#L143.
3. Run Datastore unit tests in Python 3. You can follow 
https://s.apache.org/beam-py3-conversion-quick-start for instructions. Chances 
are  some tests may still be failing for other reasons, since not all IO tests 
currently work in Python 3.

Eventually, we should run all tests in IO module as part of Python 3 presubmit 
suite, currently we only run a subset: 
https://github.com/apache/beam/blob/3e7e0346492f9c70903590c50133f9f5a5acf9ee/sdks/python/tox.ini#L61.

> Finish Python 3 porting for io module
> -------------------------------------
>
>                 Key: BEAM-5315
>                 URL: https://issues.apache.org/jira/browse/BEAM-5315
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Simon
>            Priority: Major
>          Time Spent: 4h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to