[
https://issues.apache.org/jira/browse/BEAM-5058?focusedWorklogId=155230&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155230
]
ASF GitHub Bot logged work on BEAM-5058:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/18 00:48
Start Date: 17/Oct/18 00:48
Worklog Time Spent: 10m
Work Description: udim commented on a change in pull request #6707:
[BEAM-5058] Run basic ITs in Python Precommit
URL: https://github.com/apache/beam/pull/6707#discussion_r225749774
##########
File path: sdks/python/build.gradle
##########
@@ -226,6 +228,26 @@ task directRunnerIT(dependsOn: 'installGcpTest') {
}
}
+task precommitIT(dependsOn: ['installGcpTest', 'sdist']) {
Review comment:
This task should run in parallel to the rest of the precommit tasks. This
can be done if it is placed in a separate sub-project. Sub-projects are created
by creating a new build.gradle file in a subdirectory, such as
`sdks/python/precommit/dataflow/build.gradle`. (example of making tests
parallel: https://github.com/apache/beam/pull/5731/files)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 155230)
Time Spent: 0.5h (was: 20m)
> Python precommits should run E2E tests
> --------------------------------------
>
> Key: BEAM-5058
> URL: https://issues.apache.org/jira/browse/BEAM-5058
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core, testing
> Reporter: Udi Meiri
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> According to [https://beam.apache.org/contribute/testing/] (which I'm working
> on), end-to-end tests should be run in precommit on each combination of
> \{batch, streaming}x\{SDK language}x\{supported runner}.
> At least 2 tests need to be added to Python's precommit: wordcount and
> wordcount_streaming on Dataflow, and possibly on other supported runners
> (direct runner and new runners plz).
> These tests should be configured to run from a Gradle sub-project, so that
> they're run in parallel to the unit tests.
> Example that parallelizes Java precommit integration tests:
> [https://github.com/apache/beam/pull/5731]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
