[
https://issues.apache.org/jira/browse/BEAM-1240?focusedWorklogId=155329&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155329
]
ASF GitHub Bot logged work on BEAM-1240:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/18 09:56
Start Date: 17/Oct/18 09:56
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #1729:
[BEAM-1240] Create RabbitMqIO
URL: https://github.com/apache/beam/pull/1729#discussion_r225856265
##########
File path:
sdks/java/io/rabbitmq/src/test/java/org/apache/beam/sdk/io/rabbitmq/RabbitMqIOTest.java
##########
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.rabbitmq;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import com.rabbitmq.client.AMQP;
+import com.rabbitmq.client.Channel;
+import com.rabbitmq.client.Connection;
+import com.rabbitmq.client.ConnectionFactory;
+import com.rabbitmq.client.Consumer;
+import com.rabbitmq.client.DefaultConsumer;
+import com.rabbitmq.client.Envelope;
+import java.io.IOException;
+import java.io.Serializable;
+import java.net.ServerSocket;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.IntStream;
+import org.apache.beam.sdk.testing.PAssert;
+import org.apache.beam.sdk.testing.TestPipeline;
+import org.apache.beam.sdk.transforms.Create;
+import org.apache.beam.sdk.transforms.MapElements;
+import org.apache.beam.sdk.values.PCollection;
+import org.apache.beam.sdk.values.TypeDescriptors;
+import org.apache.qpid.server.Broker;
+import org.apache.qpid.server.BrokerOptions;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/** Test of {@link RabbitMqIO}. */
+@RunWith(JUnit4.class)
+public class RabbitMqIOTest implements Serializable {
+ private static final Logger LOG =
LoggerFactory.getLogger(RabbitMqIOTest.class);
+
+ private static int port;
+ @ClassRule public static TemporaryFolder temporaryFolder = new
TemporaryFolder();
+
+ @Rule public transient TestPipeline p = TestPipeline.create();
+
+ private static transient Broker broker;
+
+ @BeforeClass
+ public static void startBroker() throws Exception {
+ try (ServerSocket serverSocket = new ServerSocket(0)) {
+ port = serverSocket.getLocalPort();
+ }
+
+ System.setProperty("derby.stream.error.field", "MyApp.DEV_NULL");
+ broker = new Broker();
+ BrokerOptions options = new BrokerOptions();
+ options.setConfigProperty(BrokerOptions.QPID_AMQP_PORT,
String.valueOf(port));
+ options.setConfigProperty(BrokerOptions.QPID_WORK_DIR,
temporaryFolder.newFolder().toString());
+ options.setConfigProperty(BrokerOptions.QPID_HOME_DIR, "src/test/qpid");
+ broker.startup(options);
+ }
+
+ @AfterClass
+ public static void stopBroker() {
+ broker.shutdown();
+ }
+
+ @Test
+ public void testReadQueue() throws Exception {
+ final int maxNumRecords = 10;
+ PCollection<RabbitMqMessage> raw =
+ p.apply(
+ RabbitMqIO.read()
+ .withUri("amqp://guest:guest@localhost:" + port)
+ .withQueue("READ")
+ .withMaxNumRecords(maxNumRecords));
+ PCollection<String> output =
+ raw.apply(
+ MapElements.into(TypeDescriptors.strings())
+ .via(
+ (RabbitMqMessage message) ->
+ new String(message.getBody(),
StandardCharsets.UTF_8)));
+
+ List<String> records =
+ generateRecords(maxNumRecords)
+ .stream()
+ .map(record -> new String(record, StandardCharsets.UTF_8))
+ .collect(Collectors.toList());
+ PAssert.that(output).containsInAnyOrder(records);
+
+ ConnectionFactory connectionFactory = new ConnectionFactory();
+ connectionFactory.setUri("amqp://guest:guest@localhost:" + port);
+ Connection connection = null;
+ Channel channel = null;
+ try {
+ connection = connectionFactory.newConnection();
+ channel = connection.createChannel();
+ channel.queueDeclare("READ", false, false, false, null);
+ for (String record : records) {
+ channel.basicPublish("", "READ", null,
record.getBytes(StandardCharsets.UTF_8));
+ }
+
+ p.run();
+ } finally {
+ if (channel != null) {
+ channel.close();
+ }
+ if (connection != null) {
+ connection.close();
+ }
+ }
+ }
+
+ @Test(timeout = 60 * 1000)
+ public void testReadExchange() throws Exception {
+ final int maxNumRecords = 10;
+ PCollection<RabbitMqMessage> raw =
+ p.apply(
+ RabbitMqIO.read()
+ .withUri("amqp://guest:guest@localhost:" + port)
+ .withExchange("READEXCHANGE", "fanout", "test")
+ .withMaxNumRecords(maxNumRecords));
+ PCollection<String> output =
+ raw.apply(
+ MapElements.into(TypeDescriptors.strings())
+ .via(
+ (RabbitMqMessage message) ->
+ new String(message.getBody(),
StandardCharsets.UTF_8)));
+
+ List<String> records =
+ generateRecords(maxNumRecords)
+ .stream()
+ .map(record -> new String(record, StandardCharsets.UTF_8))
+ .collect(Collectors.toList());
+ PAssert.that(output).containsInAnyOrder(records);
+
+ ConnectionFactory connectionFactory = new ConnectionFactory();
+ connectionFactory.setUri("amqp://guest:guest@localhost:" + port);
+ Connection connection = null;
+ Channel channel = null;
+ try {
+ connection = connectionFactory.newConnection();
+ channel = connection.createChannel();
+ channel.exchangeDeclare("READEXCHANGE", "fanout");
+ Channel finalChannel = channel;
+ Thread publisher =
+ new Thread(
+ () -> {
+ try {
+ Thread.sleep(5000);
+ } catch (Exception e) {
+ LOG.error(e.getMessage(), e);
+ }
+ for (int i = 0; i < 10; i++) {
+ try {
+ finalChannel.basicPublish(
+ "READEXCHANGE",
+ "test",
+ null,
+ ("Test " + i).getBytes(StandardCharsets.UTF_8));
+ } catch (Exception e) {
+ LOG.error(e.getMessage(), e);
+ }
+ }
+ });
+ publisher.start();
+ p.run();
+ publisher.join();
+ } finally {
+ if (channel != null) {
+ channel.close();
+ }
+ if (connection != null) {
+ connection.close();
+ }
+ }
+ }
+
+ @Test
+ public void testWriteQueue() throws Exception {
+ final int maxNumRecords = 1000;
+ List<RabbitMqMessage> data =
+ generateRecords(maxNumRecords)
+ .stream()
+ .map(bytes -> new RabbitMqMessage(bytes))
+ .collect(Collectors.toList());
+ p.apply(Create.of(data))
+ .apply(
+ RabbitMqIO.write().withUri("amqp://guest:guest@localhost:" +
port).withQueue("TEST"));
+
+ final List<String> received = new ArrayList<>();
+ ConnectionFactory connectionFactory = new ConnectionFactory();
+ connectionFactory.setUri("amqp://guest:guest@localhost:" + port);
+ Connection connection = null;
+ Channel channel = null;
+ try {
+ connection = connectionFactory.newConnection();
+ channel = connection.createChannel();
+ channel.queueDeclare("TEST", true, false, false, null);
+ Consumer consumer = new TestConsumer(channel, received);
+ channel.basicConsume("TEST", true, consumer);
+
+ p.run();
+
+ while (received.size() < maxNumRecords) {
+ Thread.sleep(500);
Review comment:
There is no problem with this sleep because it is not a wait for an absolute
period of time but more a way to temporise the check of the receive queue
depth. As a very minor suggestion (only if you feel the envy :) ), I would
implement it with a new CountDownLatch(maxNumRecords); countdown.await() and
countdown.countDown in the TestConsumer when it receives a message.
But once again it is very minor way to reduce test time a tiny bit but I'm
ok with current impl
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 155329)
> Create RabbitMqIO
> -----------------
>
> Key: BEAM-1240
> URL: https://issues.apache.org/jira/browse/BEAM-1240
> Project: Beam
> Issue Type: New Feature
> Components: io-ideas
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 2.8.0
>
> Time Spent: 13.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
