[ https://issues.apache.org/jira/browse/BEAM-5707?focusedWorklogId=155970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155970 ]
ASF GitHub Bot logged work on BEAM-5707: ---------------------------------------- Author: ASF GitHub Bot Created on: 18/Oct/18 16:04 Start Date: 18/Oct/18 16:04 Worklog Time Spent: 10m Work Description: tweise commented on a change in pull request #6737: [BEAM-5707] Add support for options to flink_streaming_impulse.py URL: https://github.com/apache/beam/pull/6737#discussion_r226368403 ########## File path: sdks/python/apache_beam/examples/flink/flink_streaming_impulse.py ########## @@ -57,15 +58,24 @@ def run(argv=None): args.extend(argv) parser = argparse.ArgumentParser() - _, pipeline_args = parser.parse_known_args(args) + parser.add_argument('--count', + dest='message_count', + default=10000, + help='Number of records to generate.') + parser.add_argument('--interval_ms', + dest='interval_ms', + default=500, + help='Interval between records.') + + known_args, pipeline_args = parser.parse_known_args(args) pipeline_options = PipelineOptions(pipeline_args) p = beam.Pipeline(options=pipeline_options) messages = (p | FlinkStreamingImpulseSource() - .set_message_count(10000) - .set_interval_ms(500)) + .set_message_count(known_args.message_count) Review comment: Thanks, will keep that in mind for future work. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 155970) Time Spent: 6.5h (was: 6h 20m) > Add a portable Flink streaming synthetic source for testing > ----------------------------------------------------------- > > Key: BEAM-5707 > URL: https://issues.apache.org/jira/browse/BEAM-5707 > Project: Beam > Issue Type: Improvement > Components: runner-flink > Reporter: Micah Wylde > Assignee: Micah Wylde > Priority: Minor > Fix For: 2.9.0 > > Time Spent: 6.5h > Remaining Estimate: 0h > > Currently there are no built-in streaming sources for portable pipelines. > This makes it hard to test streaming functionality in the Python SDK. > It would be very useful to add a periodic impulse source that (with some > configurable frequency) outputs an empty byte array, which can then be > transformed as desired inside the python pipeline. More context in this > [mailing list > discussion|https://lists.apache.org/thread.html/b44a648ab1d0cb200d8bfe4b280e9dad6368209c4725609cbfbbe410@%3Cdev.beam.apache.org%3E]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)