[
https://issues.apache.org/jira/browse/BEAM-5467?focusedWorklogId=156205&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-156205
]
ASF GitHub Bot logged work on BEAM-5467:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Oct/18 01:34
Start Date: 19/Oct/18 01:34
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #6532:
[BEAM-5467] Use process SDKHarness to run flink PVR tests.
URL: https://github.com/apache/beam/pull/6532#discussion_r226513269
##########
File path: sdks/python/build.gradle
##########
@@ -379,3 +405,21 @@ task buildSnapshot() {
dependsOn 'sdist'
dependsOn 'depSnapshot'
}
+
+project.task('createProcessWorker') {
+ dependsOn ':beam-sdks-python-container:build'
+ dependsOn 'setupVirtualenv'
+ def sdkWorkerFile = file("${project.buildDir}/sdk_worker.sh")
+ def workerScript =
"${project(":beam-sdks-python-container:").buildDir.absolutePath}/target/launcher/linux_amd64/boot"
+ def sdkWorkerFileCode = "sh -c \". ${envdir}/bin/activate && ${workerScript}
\$* \""
Review comment:
Since we are basically doing the same thing with the process environment at
Lyft, I still don't understand what the issue is. It is an invocation of sh -c
'...' and unless I have missed something the shell command string doesn't
require any escaping. Having said that, I don't want to block the rest of the
PR if it helps to stabilize the CI job. Let's take it as follow-up, I would
prefer we can simplify the build script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 156205)
Time Spent: 11.5h (was: 11h 20m)
> Python Flink ValidatesRunner job fixes
> --------------------------------------
>
> Key: BEAM-5467
> URL: https://issues.apache.org/jira/browse/BEAM-5467
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Minor
> Labels: portability-flink
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> Add status to README
> Rename script and job for consistency
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
