[
https://issues.apache.org/jira/browse/BEAM-5617?focusedWorklogId=156893&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-156893
]
ASF GitHub Bot logged work on BEAM-5617:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/18 18:30
Start Date: 22/Oct/18 18:30
Worklog Time Spent: 10m
Work Description: robertwb closed pull request #6764: [BEAM-5617] Fix
Python 3 incompatibility in pickler.
URL: https://github.com/apache/beam/pull/6764
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/apache_beam/internal/pickler.py
b/sdks/python/apache_beam/internal/pickler.py
index f93c5341594..234914a000a 100644
--- a/sdks/python/apache_beam/internal/pickler.py
+++ b/sdks/python/apache_beam/internal/pickler.py
@@ -55,7 +55,8 @@
def _is_nested_class(cls):
"""Returns true if argument is a class object that appears to be nested."""
return (isinstance(cls, type)
- and cls.__module__ != '__builtin__'
+ and cls.__module__ != 'builtins' # Python 3
+ and cls.__module__ != '__builtin__' # Python 2
and cls.__name__ not in sys.modules[cls.__module__].__dict__)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 156893)
Time Spent: 0.5h (was: 20m)
> Several tests fail on Python 3 with failed assert: <some non-empty list> == []
> ------------------------------------------------------------------------------
>
> Key: BEAM-5617
> URL: https://issues.apache.org/jira/browse/BEAM-5617
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Valentyn Tymofieiev
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> ======================================================================
> ERROR: test_iterable_side_input
> (apache_beam.transforms.sideinputs_test.SideInputsTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/common.py",
> line 677, in process
> self.do_fn_invoker.invoke_process(windowed_value)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/common.py",
> line 414, in invoke_process
> windowed_value, self.process_method(windowed_value.value))
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/core.py",
> line 1068, in <lambda>
> wrapper = lambda x: [fn(x)]
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/testing/util.py",
> line 119, in _equal
> 'Failed assert: %r == %r' % (sorted_expected, sorted_actual))
> apache_beam.testing.util.BeamAssertException: Failed assert: [3, 4, 6, 8] ==
> []
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
