[
https://issues.apache.org/jira/browse/BEAM-2918?focusedWorklogId=156914&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-156914
]
ASF GitHub Bot logged work on BEAM-2918:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/18 18:42
Start Date: 22/Oct/18 18:42
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #6726:
[BEAM-2918] Add state support for streaming in portable FlinkRunner
URL: https://github.com/apache/beam/pull/6726#discussion_r226972070
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -52,19 +60,22 @@
import org.apache.beam.sdk.values.PCollectionView;
import org.apache.beam.sdk.values.TupleTag;
import org.apache.beam.sdk.values.WindowingStrategy;
+import org.apache.flink.api.java.functions.KeySelector;
import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
import org.joda.time.Instant;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
- * ExecutableStageDoFnOperator basic functional implementation without side
inputs and user state.
- * SDK harness interaction code adopted from {@link
- *
org.apache.beam.runners.flink.translation.functions.FlinkExecutableStageFunction}.
TODO: Evaluate
- * reuse All operators in the non-portable streaming translation are based on
{@link DoFnOperator}.
- * This implies dependency on {@link DoFnRunner}, which is not required for
portable pipeline. TODO:
- * Multiple element bundle execution The operator (like old non-portable
runner) executes every
- * element as separate bundle, which will be even more expensive with SDK
harness container.
+ * ExecutableStageDoFnOperator basic functional implementation. SDK harness
interaction code adopted
Review comment:
We can scratch this (since it is no longer relevant) and should also update
rest of the JavaDoc block (I initially thought you did, but this looks like
formatting only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 156914)
Time Spent: 4h 20m (was: 4h 10m)
> Flink support for portable user state
> -------------------------------------
>
> Key: BEAM-2918
> URL: https://issues.apache.org/jira/browse/BEAM-2918
> Project: Beam
> Issue Type: Sub-task
> Components: runner-flink
> Reporter: Henning Rohde
> Assignee: Maximilian Michels
> Priority: Minor
> Labels: portability
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
