[
https://issues.apache.org/jira/browse/BEAM-5445?focusedWorklogId=157192&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157192
]
ASF GitHub Bot logged work on BEAM-5445:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/18 20:49
Start Date: 22/Oct/18 20:49
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#6478: [BEAM-5445] [BEAM-4796] [BEAM-3516] SpannerIO: Only batch on the current
bundle. Adds streaming support
URL: https://github.com/apache/beam/pull/6478#discussion_r226747963
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
##########
@@ -781,11 +817,29 @@ public Write withFailureMode(FailureMode failureMode) {
return toBuilder().setFailureMode(failureMode).build();
}
- /** Specifies the cell mutation limit. */
+ /** Specifies the cell mutation limit (maxumum number of mutated cells per
batch). */
public Write withMaxNumMutations(long maxNumMutations) {
return toBuilder().setMaxNumMutations(maxNumMutations).build();
}
+ /**
+ * Specifies an input PCollection that can be used with a {@code
Wait.on(signal)} to indicate
+ * when the database schema is ready. To be used when the schema creation
is part of the
+ * pipeline to prevent the connector reading the schema too early.
+ */
+ public Write withSchemaReadySignal(PCollection signal) {
+ return toBuilder().setSchemaReadySignal(signal).build();
+ }
+
+ /**
+ * Specifies the multiple of max mutation size that is used to select a
set of mutations to sort
+ * by key for batching. This uses local disk on the workers, so large
values can cause out of
Review comment:
It might be better to run a extra Datafllow shuffle here instead of using
local disks. A shuffle might be bit expensive today compared to local disks but
should get better since we are moving to shuffle service. (you can also try
running with the shuffle service experiment).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 157192)
Time Spent: 3h 20m (was: 3h 10m)
> Update SpannerIO to support unbounded writes
> --------------------------------------------
>
> Key: BEAM-5445
> URL: https://issues.apache.org/jira/browse/BEAM-5445
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Chamikara Jayalath
> Assignee: Niel Markwick
> Priority: Major
> Fix For: 2.9.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently, due to a known issue, streaming pipelines that use SpannerIO.Write
> do not actually write to Spanner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
