[
https://issues.apache.org/jira/browse/BEAM-3612?focusedWorklogId=157730&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157730
]
ASF GitHub Bot logged work on BEAM-3612:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/18 17:34
Start Date: 23/Oct/18 17:34
Worklog Time Spent: 10m
Work Description: aaltay closed pull request #6795: [BEAM-3612] Make
function registration idempotent
URL: https://github.com/apache/beam/pull/6795
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/go/pkg/beam/core/runtime/symbols.go
b/sdks/go/pkg/beam/core/runtime/symbols.go
index c4f68163393..f5089f1e3fd 100644
--- a/sdks/go/pkg/beam/core/runtime/symbols.go
+++ b/sdks/go/pkg/beam/core/runtime/symbols.go
@@ -79,9 +79,7 @@ func RegisterFunction(fn interface{}) {
}
key := reflectx.FunctionName(fn)
- if _, exists := cache[key]; exists {
- panic(fmt.Sprintf("Function %v already registred", key))
- }
+ // If the function was registered already, the key and value will be
the same anyway.
cache[key] = fn
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 157730)
Time Spent: 2h (was: 1h 50m)
> Make it easy to generate type-specialized Go SDK reflectx.Funcs
> ---------------------------------------------------------------
>
> Key: BEAM-3612
> URL: https://issues.apache.org/jira/browse/BEAM-3612
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
