[
https://issues.apache.org/jira/browse/BEAM-5845?focusedWorklogId=157876&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157876
]
ASF GitHub Bot logged work on BEAM-5845:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/18 23:15
Start Date: 23/Oct/18 23:15
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #6802:
[BEAM-5845] Split Dataflow run of examples precommit to its own job
URL: https://github.com/apache/beam/pull/6802#discussion_r227596098
##########
File path: .test-infra/jenkins/job_PreCommit_Java_Examples_Dataflow.groovy
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import PrecommitJobBuilder
+
+PrecommitJobBuilder builder = new PrecommitJobBuilder(
+ scope: this,
+ nameBase: 'Java Examples Dataflow',
+ gradleTask: ':beam-runners-google-cloud-dataflow-java-examples:preCommit',
Review comment:
For other jobs we create a top-level `xyzPrecommit` task in the root build
script. I don't know how the pattern was established, but it has some benefits:
1. Less logic in the Jenkins jobs, which aren't scoped to a commit and are
more difficult to change. This way we can always refactor the project tree
without messing with Jenkins.
1. Better discoverability, and easier to type than the super-long project
name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 157876)
> Precommit time (1h15m) includes 20m of Dataflow integration tests
> -----------------------------------------------------------------
>
> Key: BEAM-5845
> URL: https://issues.apache.org/jira/browse/BEAM-5845
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
