[ 
https://issues.apache.org/jira/browse/BEAM-5851?focusedWorklogId=158372&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-158372
 ]

ASF GitHub Bot logged work on BEAM-5851:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Oct/18 23:00
            Start Date: 24/Oct/18 23:00
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on issue #6815: [BEAM-5851] Update 
.gitignore file to remove IntelliJ generated gradle files
URL: https://github.com/apache/beam/pull/6815#issuecomment-432856763
 
 
   R: @swegner 
   
   Intellij provides a button where the "full" version of Gradle can be fetched 
and used so that you get symbol lookups in Intellij when editing gradle files.
   
   This `.gitignore` update will prevent "accidental" updates caused by users 
clicking that button in Intellij but will require devs who are specifically 
updating Gradle to use something like `git add --force <FILE>` to ensure it 
gets added.
   
   The other thing is that our RAT check excludes everything in `.gitignore` 
which would mean that we would stop checking 
gradle-wrapper.properties/gradlew/gradlew.bat for license headers.
   
   Do you think we should go with this or just be diligent during reviews to 
prevent accidental overwriting of these files?
   
   Also, for users who want to click that button, they could be told to use a 
local `.gitignore` 
(https://medium.com/@peter_graham/how-to-create-a-local-gitignore-1b19f083492b) 
to avoid the annoying problem of git adding the changes to your commits.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 158372)
    Time Spent: 0.5h  (was: 20m)

> Update .gitignore file to remove IntelliJ generated gradle files
> ----------------------------------------------------------------
>
>                 Key: BEAM-5851
>                 URL: https://issues.apache.org/jira/browse/BEAM-5851
>             Project: Beam
>          Issue Type: New Feature
>          Components: build-system
>            Reporter: Alex Amato
>            Assignee: Alex Amato
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to