[ 
https://issues.apache.org/jira/browse/BEAM-5884?focusedWorklogId=159774&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159774
 ]

ASF GitHub Bot logged work on BEAM-5884:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Oct/18 21:44
            Start Date: 28/Oct/18 21:44
    Worklog Time Spent: 10m 
      Work Description: amaliujia edited a comment on issue #6861: [BEAM-5884] 
support null values in Array and Map.
URL: https://github.com/apache/beam/pull/6861#issuecomment-433744006
 
 
   Yes. It is adding `ARRAY<NULLABLE<T>>`, and `NULLABLE<ARRAY<T>>` exists in 
current Beam implementation as a nullable flag of `Field`.
   
   The reason I think container type should has `nullable`, is there is a 
difference between `NULLABLE<ARRAY<T>>` (which is a flag in `Array Field`) and 
`ARRAY<NULLABLE<T>>` (which is flag for container type `T`).  
   
   It's two difference concepts:
   1. `ARRAY` as a field (or type) can be `null`. E.g. `a null array`.
   2. `ARRAY element type` can be `null`. E.g. `array<int32>(1, 2, null, 3, 
null)`.
   
   So there could be a `not nullable ARRAY` field with a `nullable element 
type`, which is not a conflict.
   
   I also think both nullable flag has use cases:
   1. messages ingested from message queue contains `null` for `Array Field`.
   2. In the intermediate stages, it generates `null` for `array element`.
   
   In this PR, I make `not nullable` as the default setting.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 159774)
    Time Spent: 2h 50m  (was: 2h 40m)

> Allow nested types have null value.
> -----------------------------------
>
>                 Key: BEAM-5884
>                 URL: https://issues.apache.org/jira/browse/BEAM-5884
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: Major
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> We could allow arbitrary combination of nested types have null value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to