[
https://issues.apache.org/jira/browse/BEAM-5909?focusedWorklogId=160097&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160097
]
ASF GitHub Bot logged work on BEAM-5909:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/18 17:31
Start Date: 29/Oct/18 17:31
Worklog Time Spent: 10m
Work Description: mxm closed pull request #6869: [BEAM-5909] Filter timer
PCollections in QueryablePipelines#getUserState
URL: https://github.com/apache/beam/pull/6869
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/QueryablePipeline.java
b/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/QueryablePipeline.java
index 266d02c7b05..280e705db6c 100644
---
a/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/QueryablePipeline.java
+++
b/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/QueryablePipeline.java
@@ -362,7 +362,10 @@ public Components getComponents() {
Iterables.getOnlyElement(
Sets.difference(
transform.getTransform().getInputsMap().keySet(),
- getLocalSideInputNames(transformProto))));
+ ImmutableSet.builder()
+
.addAll(getLocalSideInputNames(transformProto))
+
.addAll(getLocalTimerNames(transformProto))
+ .build())));
PCollection collection =
components.getPcollectionsOrThrow(collectionId);
return UserStateReference.of(
PipelineNode.pTransform(transformId, transformProto),
diff --git
a/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/graph/GreedyPipelineFuserTest.java
b/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/graph/GreedyPipelineFuserTest.java
index bea936dfe90..b89e380f0a9 100644
---
a/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/graph/GreedyPipelineFuserTest.java
+++
b/runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/graph/GreedyPipelineFuserTest.java
@@ -1049,6 +1049,57 @@ public void parDoWithTimerRootsStage() {
ExecutableStageMatcher.withInput("parDo.out").withNoOutputs().withTransforms("timer")));
}
+ /*
+ * Tests that parDo with state and timers is fused correctly and can be
queried
+ * impulse -> .out -> timer -> .out
+ * becomes
+ * (impulse.out) -> timer
+ */
+ @Test
+ public void parDoWithStateAndTimerRootsStage() {
+ PTransform timerTransform =
+ PTransform.newBuilder()
+ .setUniqueName("TimerParDo")
+ .putInputs("input", "impulse.out")
+ .putInputs("timer", "timer.out")
+ .putOutputs("timer", "timer.out")
+ .putOutputs("output", "output.out")
+ .setSpec(
+ FunctionSpec.newBuilder()
+ .setUrn(PTransformTranslation.PAR_DO_TRANSFORM_URN)
+ .setPayload(
+ ParDoPayload.newBuilder()
+
.setDoFn(SdkFunctionSpec.newBuilder().setEnvironmentId("common"))
+ .putStateSpecs("state",
StateSpec.getDefaultInstance())
+ .putTimerSpecs("timer",
TimerSpec.getDefaultInstance())
+ .build()
+ .toByteString()))
+ .build();
+
+ Components components =
+ partialComponents
+ .toBuilder()
+ .putTransforms("timer", timerTransform)
+ .putPcollections("timer.out", pc("timer.out"))
+ .putPcollections("output.out", pc("output.out"))
+ .putEnvironments("common",
Environments.createDockerEnvironment("common"))
+ .build();
+
+ FusedPipeline fused =
+
GreedyPipelineFuser.fuse(Pipeline.newBuilder().setComponents(components).build());
+
+ assertThat(
+ fused.getRunnerExecutedTransforms(),
+ containsInAnyOrder(
+ PipelineNode.pTransform("impulse",
components.getTransformsOrThrow("impulse"))));
+ assertThat(
+ fused.getFusedStages(),
+ contains(
+ ExecutableStageMatcher.withInput("impulse.out")
+ .withNoOutputs()
+ .withTransforms("timer")));
+ }
+
/*
* impulse -> .out -> ( read -> .out --> goTransform -> .out )
* \
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 160097)
Time Spent: 50m (was: 40m)
> QueryablePipeline fails to lookup UserState with Timers
> -------------------------------------------------------
>
> Key: BEAM-5909
> URL: https://issues.apache.org/jira/browse/BEAM-5909
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Minor
> Fix For: 2.9.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> QueryablePipeline fails when given a ParDo with both state and timers,
> similar to the example in
> https://beam.apache.org/blog/2017/08/28/timely-processing.html#event-time-timers:
> {noformat}
> java.lang.IllegalArgumentException: expected one element but was:
> <org.apache.beam.sdk.values.PCollection.<init>:402#3d93cb799b3970be, expiry>
> at
> org.apache.beam.repackaged.beam_runners_core_construction_java.com.google.common.collect.Iterators.getOnlyElement(Iterators.java:322)
> at
> org.apache.beam.repackaged.beam_runners_core_construction_java.com.google.common.collect.Iterables.getOnlyElement(Iterables.java:294)
> at
> org.apache.beam.runners.core.construction.graph.QueryablePipeline.lambda$getUserStates$10(QueryablePipeline.java:362)
> at
> java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
> at java.util.Iterator.forEachRemaining(Iterator.java:116)
> at
> java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at
> java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
> at
> java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
> at
> java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at
> java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
> at
> org.apache.beam.runners.core.construction.graph.QueryablePipeline.getUserStates(QueryablePipeline.java:372)
> at
> org.apache.beam.runners.core.construction.graph.GreedyStageFuser.forGrpcPortRead(GreedyStageFuser.java:92)
> at
> org.apache.beam.runners.core.construction.graph.GreedyPipelineFuser.fuseSiblings(GreedyPipelineFuser.java:340)
> at
> org.apache.beam.runners.core.construction.graph.GreedyPipelineFuser.fusePipeline(GreedyPipelineFuser.java:142)
> at
> org.apache.beam.runners.core.construction.graph.GreedyPipelineFuser.<init>(GreedyPipelineFuser.java:75)
> at
> org.apache.beam.runners.core.construction.graph.GreedyPipelineFuser.fuse(GreedyPipelineFuser.java:88)
> at
> org.apache.beam.runners.flink.FlinkJobInvocation.runPipeline(FlinkJobInvocation.java:96)
> at
> org.apache.beam.repackaged.beam_runners_flink_2.11.com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:111)
> at
> org.apache.beam.repackaged.beam_runners_flink_2.11.com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:58)
> at
> org.apache.beam.repackaged.beam_runners_flink_2.11.com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:75)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
