[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160277&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160277
]
ASF GitHub Bot logged work on BEAM-5887:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/18 22:35
Start Date: 29/Oct/18 22:35
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-434106134
Interesting. Can you put up your change? I had noticed the use of mocks
shared between threads, which is explicitly unsupported by Mockito, yet I'm not
sure our tests really are wrong. I figured we just needed to rewrite these
tests a different way. If we can do it with a latch, that's even better quick
fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 160277)
Time Spent: 4h 20m (was: 4h 10m)
> packageTests and shadowTestJar write the same file
> --------------------------------------------------
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
