[ https://issues.apache.org/jira/browse/BEAM-5921?focusedWorklogId=161677&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-161677 ]
ASF GitHub Bot logged work on BEAM-5921: ---------------------------------------- Author: ASF GitHub Bot Created on: 01/Nov/18 18:18 Start Date: 01/Nov/18 18:18 Worklog Time Spent: 10m Work Description: XuMingmin commented on issue #6913: [BEAM-5921] [SQL] Support Joda types for UDF arguments URL: https://github.com/apache/beam/pull/6913#issuecomment-435135764 R: @akedin @amaliujia @apilloud ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 161677) Time Spent: 20m (was: 10m) > [SQL] Support Joda types for UDF arguments > ------------------------------------------ > > Key: BEAM-5921 > URL: https://issues.apache.org/jira/browse/BEAM-5921 > Project: Beam > Issue Type: Bug > Components: dsl-sql > Reporter: Anton Kedin > Assignee: Xu Mingmin > Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > We call ScalarFunctionImpl.create() to register a UDF with Calcite schema in > BeamSqlEnv. Internally it uses Calcite's internal mapping > (JavaToSqlTypeConversionRules) to map Java types to SQL types to create a > function signature that gets registered in the schema. Problem is that this > logic is not extensible and doesn't include Joda types support (maybe others > as well). > We can work around this by constructing our own subclass of Function that > gets registered in the schema instead of calling ScalarFunctionImpl.create(). > This logic can use our own custom mapping (or fall back to Calcite > implementation if needed). -- This message was sent by Atlassian JIRA (v7.6.3#76005)