[
https://issues.apache.org/jira/browse/BEAM-5931?focusedWorklogId=161752&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-161752
]
ASF GitHub Bot logged work on BEAM-5931:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/18 21:29
Start Date: 01/Nov/18 21:29
Worklog Time Spent: 10m
Work Description: HuangLED commented on issue #6916: [BEAM-5931] Update
nexmark performance test with dataflow worker jar
URL: https://github.com/apache/beam/pull/6916#issuecomment-435193707
Note that in a update-to-head repo with this PR, I applied a revert-revert,
it passes as well with the command line above.
However, as a comparison, in another repo WITHOUT this PR, I applied a
revert-revert, the above command also passed. Could just because there are
other test cases in the jenkins spec file. I will try a few more test case if
we can reproduce.
At this point it probably does not matter though, as long as this fix is
something should be done and passes. Just FYI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 161752)
Time Spent: 0.5h (was: 20m)
> Rollback PR/6899
> ----------------
>
> Key: BEAM-5931
> URL: https://issues.apache.org/jira/browse/BEAM-5931
> Project: Beam
> Issue Type: Task
> Components: beam-model, runner-dataflow
> Reporter: Luke Cwik
> Assignee: Ruoyun Huang
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> To rollback this change, one must either:
> 1) Update nexmark / perf test framework to use Dataflow worker jar.
> This requires adding the
> {code}
> "--dataflowWorkerJar=${dataflowWorkerJar}",
> "--workerHarnessContainerImage=",
> {code}
> when running the tests.
> OR
> 2) Update the dataflow worker image with code that contains the rollback of
> PR/6899 and then rollback PR/6899 in Github with the updated Dataflow worker
> image.
> #1 is preferable since we will no longer have tests running that don't use a
> Dataflow worker jar built from Github HEAD.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
