[ 
https://issues.apache.org/jira/browse/BEAM-5931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672364#comment-16672364
 ] 

Ruoyun Huang commented on BEAM-5931:
------------------------------------

Update: 

For the nexmark case, PR#6916 is sent. 

 

For the TextIO case, we will need more time as this groovy file is hard to test 
locally. I am trying to make [Local Dockerized 
Jenkins|https://github.com/apache/beam/tree/master/.test-infra/dockerized-jenkins]
 work on my machine, but if there is better alternative, please kindly share 
with me. 

Also a question:  worker jar flag depends on a jar file created by gradle 
(specified by a path).  What is the best practise to create the dependency 
between genkins and gradle? (and in particular to pass the path string from 
gradle to jenkins, or vice versa).   

 

> Rollback PR/6899
> ----------------
>
>                 Key: BEAM-5931
>                 URL: https://issues.apache.org/jira/browse/BEAM-5931
>             Project: Beam
>          Issue Type: Task
>          Components: beam-model, runner-dataflow
>            Reporter: Luke Cwik
>            Assignee: Ruoyun Huang
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> To rollback this change, one must either:
> 1) Update nexmark / perf test framework to use Dataflow worker jar.
> This requires adding the 
> {code}
>      "--dataflowWorkerJar=${dataflowWorkerJar}",
>      "--workerHarnessContainerImage=",
> {code}
> when running the tests.
> OR
> 2) Update the dataflow worker image with code that contains the rollback of 
> PR/6899 and then rollback PR/6899 in Github with the updated Dataflow worker 
> image.
> #1 is preferable since we will no longer have tests running that don't use a 
> Dataflow worker jar built from Github HEAD.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to