[ https://issues.apache.org/jira/browse/BEAM-3741?focusedWorklogId=164085&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-164085 ]
ASF GitHub Bot logged work on BEAM-3741: ---------------------------------------- Author: ASF GitHub Bot Created on: 08/Nov/18 20:59 Start Date: 08/Nov/18 20:59 Worklog Time Spent: 10m Work Description: swegner commented on a change in pull request #6963: [BEAM-3741] Proto changes for reporting backlog/splitting/finalizing bundles. URL: https://github.com/apache/beam/pull/6963#discussion_r232052086 ########## File path: model/fn-execution/src/main/proto/beam_fn_api.proto ########## @@ -184,55 +187,72 @@ message ProcessBundleDescriptor { org.apache.beam.model.pipeline.v1.ApiServiceDescriptor state_api_service_descriptor = 7; } -// Represents a partition of the bundle into two bundles: a "primary" and -// a "residual", with the following properties: -// - The work in primary and residual doesn't overlap, and combined, adds up -// to the work in the current bundle if the split hadn't happened. -// - The current bundle, if it keeps executing, will have done none of the -// work under residual roots. -// - The current bundle, if no further splits happen, will have done exactly -// the work under primary_roots. -// For more rigorous definitions see https://s.apache.org/beam-breaking-fusion -message BundleSplit { - // One of the root applications specifying the scope of work for a bundle. - message Application { - // (Required) The primitive transform to which to pass the element - string ptransform_id = 1; +// One of the applications specifying the scope of work for a bundle. +message BundleApplication { + // (Required) The primitive transform to which to pass the element + string ptransform_id = 1; Review comment: In this layer of the architecture do we talk about the difference between 'PTransform' and 'applied PTransform'? If I understand correctly, PTransform is an SDK concept which can be applied many times in a pipeline; and a bundle application refers to a specific application of a PTransform. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 164085) > Proto changes for splitting over Fn API > --------------------------------------- > > Key: BEAM-3741 > URL: https://issues.apache.org/jira/browse/BEAM-3741 > Project: Beam > Issue Type: Sub-task > Components: beam-model > Reporter: Eugene Kirpichov > Assignee: Eugene Kirpichov > Priority: Major > Fix For: 2.5.0 > > Time Spent: 6h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)