[
https://issues.apache.org/jira/browse/BEAM-5931?focusedWorklogId=163734&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-163734
]
ASF GitHub Bot logged work on BEAM-5931:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/18 23:34
Start Date: 07/Nov/18 23:34
Worklog Time Spent: 10m
Work Description: HuangLED commented on a change in pull request #6966:
[BEAM-5931] Add worker jar to integrationTest targets.
URL: https://github.com/apache/beam/pull/6966#discussion_r231718616
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1141,12 +1141,10 @@ artifactId=${project.name}
include "**/*IT.class"
- def pipelineOptionString = configuration.integrationTestPipelineOptions
- if(configuration.runner?.equalsIgnoreCase('dataflow')) {
+ def pipelineOptionsString =
configuration.integrationTestPipelineOptions
+ if(pipelineOptionsString &&
configuration.runner?.equalsIgnoreCase('dataflow')) {
Review comment:
Not sure if I understand you comment. Are you suggesting we should add our
new args, even when pipelineOptionsString starts as empty string?
I think an empty pipelineOptionsString does not happen in real use case of
dataflow task. It only happens when gradle only does evaluation, but nothing
else (e.g. ./gradle clean). In such case I make it this way that
pipelineOptionsString stays empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 163734)
Time Spent: 5h 40m (was: 5.5h)
> Rollback PR/6899
> ----------------
>
> Key: BEAM-5931
> URL: https://issues.apache.org/jira/browse/BEAM-5931
> Project: Beam
> Issue Type: Task
> Components: beam-model, runner-dataflow
> Reporter: Luke Cwik
> Assignee: Ruoyun Huang
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> To rollback this change, one must either:
> 1) Update nexmark / perf test framework to use Dataflow worker jar.
> This requires adding the
> {code}
> "--dataflowWorkerJar=${dataflowWorkerJar}",
> "--workerHarnessContainerImage=",
> {code}
> when running the tests.
> OR
> 2) Update the dataflow worker image with code that contains the rollback of
> PR/6899 and then rollback PR/6899 in Github with the updated Dataflow worker
> image.
> #1 is preferable since we will no longer have tests running that don't use a
> Dataflow worker jar built from Github HEAD.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
