[ https://issues.apache.org/jira/browse/BEAM-4681?focusedWorklogId=164236&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-164236 ]
ASF GitHub Bot logged work on BEAM-4681: ---------------------------------------- Author: ASF GitHub Bot Created on: 09/Nov/18 05:30 Start Date: 09/Nov/18 05:30 Worklog Time Spent: 10m Work Description: tweise commented on a change in pull request #6981: [BEAM-4681] Add support for portable timers in Flink streaming mode URL: https://github.com/apache/beam/pull/6981#discussion_r232144108 ########## File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java ########## @@ -2839,19 +2841,27 @@ public void testAbsoluteProcessingTimeTimerRejected() throws Exception { @ProcessElement public void processElement(@TimerId(timerId) Timer timer) { - timer.set(new Instant(0)); + try { + timer.set(new Instant(0)); + fail("Should have failed due to processing time with absolute timer."); Review comment: The error message is a b it confusing. Should it refer to "invalid processing time"? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 164236) Time Spent: 1h 20m (was: 1h 10m) > Integrate support for timers using the portability APIs into Flink > ------------------------------------------------------------------ > > Key: BEAM-4681 > URL: https://issues.apache.org/jira/browse/BEAM-4681 > Project: Beam > Issue Type: Sub-task > Components: runner-flink > Reporter: Luke Cwik > Assignee: Maximilian Michels > Priority: Major > Labels: portability, portability-flink > Time Spent: 1h 20m > Remaining Estimate: 0h > > Consider using the code produced in BEAM-4658 to support timers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)