[
https://issues.apache.org/jira/browse/BEAM-6021?focusedWorklogId=164442&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-164442
]
ASF GitHub Bot logged work on BEAM-6021:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/18 17:43
Start Date: 09/Nov/18 17:43
Worklog Time Spent: 10m
Work Description: dmvk commented on a change in pull request #6998:
[BEAM-6021] Use KryoSerializer instead of JavaSerializer
URL: https://github.com/apache/beam/pull/6998#discussion_r232334553
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/stateful/SparkGroupAlsoByWindowViaWindowSet.java
##########
@@ -97,7 +97,8 @@
private static final Logger LOG =
LoggerFactory.getLogger(SparkGroupAlsoByWindowViaWindowSet.class);
- private static class StateAndTimers implements Serializable {
+ /** State and Timers wrapper. */
+ public static class StateAndTimers implements Serializable {
Review comment:
does the class still need to be serializable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 164442)
Time Spent: 0.5h (was: 20m)
> Use Kryo spark.serializer instead of JavaSerializer
> ---------------------------------------------------
>
> Key: BEAM-6021
> URL: https://issues.apache.org/jira/browse/BEAM-6021
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark
> Affects Versions: 2.8.0
> Reporter: Marek Simunek
> Assignee: Marek Simunek
> Priority: Major
> Fix For: 2.9.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> By default is set spark.serializer=org.apache.spark.serializer.JavaSerializer.
> Because all objects from user are using Beam coders it will affect only
> internal objects for spark translation.
> So why not use more optimal {{org.apache.spark.serializer.KryoSerializer}}
> and force spark runner contributors to register classes in
> {{BeamSparkRunnerRegistrator}} by setting
> {{spark.kryo.registrationRequired=true)}}.
> More information about benefits of [kryo
> serialization|https://spark.apache.org/docs/latest/tuning.html#data-serialization]
> over java serializer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
