[
https://issues.apache.org/jira/browse/BEAM-5850?focusedWorklogId=164554&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-164554
]
ASF GitHub Bot logged work on BEAM-5850:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/18 23:42
Start Date: 09/Nov/18 23:42
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6786:
[BEAM-5850] Add BeamFnDataReceiver and make process, finish and start run on
the same thread to support metrics.
URL: https://github.com/apache/beam/pull/6786#discussion_r232424663
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/data/BeamFnDataClient.java
##########
@@ -61,4 +61,10 @@
Endpoints.ApiServiceDescriptor apiServiceDescriptor,
LogicalEndpoint outputLocation,
Coder<WindowedValue<T>> coder);
+
+ /**
+ * Drain all element queues and cleanup all objects created for the handling
of elements for the
+ * given apiServiceDescriptor representing the data channel and the
instructionId.
+ */
+ void drainAndBlock(ApiServiceDescriptor apiServiceDescriptor, String
instructionId);
Review comment:
From the description and method name, its unclear when people using the
BeamFnDataClient would ever use this method.
Also, from a code perspective, why would we need to change this?
The ProcessBundleHandler could create its own BeamFnDataClient that wraps
the real BeamFnDataClient and it contains all the queue logic / receiver
management. Since this would be internal to the ProcessBundleHandler,
processing the queue would never be exposed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 164554)
> Make process, finish and start run on the same thread to support metrics.
> -------------------------------------------------------------------------
>
> Key: BEAM-5850
> URL: https://issues.apache.org/jira/browse/BEAM-5850
> Project: Beam
> Issue Type: New Feature
> Components: java-fn-execution
> Reporter: Alex Amato
> Assignee: Alex Amato
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Update BeamFnDataReceiver to place elements into a Queue and consumer then
> and call the element processing receiver in blockTillReadFinishes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
