[
https://issues.apache.org/jira/browse/BEAM-4681?focusedWorklogId=165051&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-165051
]
ASF GitHub Bot logged work on BEAM-4681:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/18 18:31
Start Date: 12/Nov/18 18:31
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #6981:
[BEAM-4681] Add support for portable timers in Flink streaming mode
URL: https://github.com/apache/beam/pull/6981#discussion_r232766686
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -442,22 +443,21 @@ public void close() throws Exception {
}
}
- private long getPushbackWatermarkHold() {
+ long getPushbackWatermarkHold() {
Review comment:
The reason it changed from private is to make it available to the subclass.
IMO (like other similar modifier changes) it should be `protected`, because we
don't want to force subclasses to the same package. `final` is orthogonal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 165051)
Time Spent: 6h (was: 5h 50m)
> Integrate support for timers using the portability APIs into Flink
> ------------------------------------------------------------------
>
> Key: BEAM-4681
> URL: https://issues.apache.org/jira/browse/BEAM-4681
> Project: Beam
> Issue Type: Sub-task
> Components: runner-flink
> Reporter: Luke Cwik
> Assignee: Maximilian Michels
> Priority: Major
> Labels: portability, portability-flink
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Consider using the code produced in BEAM-4658 to support timers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
