[
https://issues.apache.org/jira/browse/BEAM-5953?focusedWorklogId=165111&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-165111
]
ASF GitHub Bot logged work on BEAM-5953:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/18 20:15
Start Date: 12/Nov/18 20:15
Worklog Time Spent: 10m
Work Description: markflyhigh commented on a change in pull request
#7011: [BEAM-5953] Fix DataflowRunner in Python 3 - type errors
URL: https://github.com/apache/beam/pull/7011#discussion_r232797692
##########
File path: sdks/python/apache_beam/internal/gcp/json_value.py
##########
@@ -105,7 +105,9 @@ def to_json_value(obj, with_type=False):
return extra_types.JsonValue(object_value=json_object)
elif with_type:
return to_json_value(get_typed_value_descriptor(obj), with_type=False)
- elif isinstance(obj, (str, unicode)):
+ elif isinstance(obj, (str, unicode, bytes)):
Review comment:
sg. done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 165111)
Time Spent: 40m (was: 0.5h)
> Support DataflowRunner on Python 3
> ----------------------------------
>
> Key: BEAM-5953
> URL: https://issues.apache.org/jira/browse/BEAM-5953
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
