[
https://issues.apache.org/jira/browse/BEAM-5299?focusedWorklogId=165640&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-165640
]
ASF GitHub Bot logged work on BEAM-5299:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/18 21:12
Start Date: 13/Nov/18 21:12
Worklog Time Spent: 10m
Work Description: tweise commented on issue #7012: Revert "Revert "Revert
"[BEAM-5299] Define max timestamp for global w…
URL: https://github.com/apache/beam/pull/7012#issuecomment-438438416
Yes, I think that PR reverts that originate from "internal" issues, need to
be discussed. Situations that warrant a revert are documented here:
https://beam.apache.org/contribute/postcommits-policies/
> @tweise I think any PR breaking any runner should be reverted.
That doesn't make sense. Anyone could find a problem in any runner outside
of the project and cite that as reason to revert properly reviewed PRs that
passed post-commit. I wonder how that would be received if it wasn't Dataflow,
but any other runner..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 165640)
Time Spent: 15h (was: 14h 50m)
> Define max global window as a shared value in protos like URN enums.
> --------------------------------------------------------------------
>
> Key: BEAM-5299
> URL: https://issues.apache.org/jira/browse/BEAM-5299
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, sdk-go, sdk-java-core, sdk-py-core
> Reporter: Luke Cwik
> Assignee: Maximilian Michels
> Priority: Minor
> Labels: portability
> Fix For: 2.9.0
>
> Time Spent: 15h
> Remaining Estimate: 0h
>
> Instead of having each language define a max timestamp themselves, define the
> max timestamps within proto to be shared across different languages.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
