[ 
https://issues.apache.org/jira/browse/BEAM-4524?focusedWorklogId=166962&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-166962
 ]

ASF GitHub Bot logged work on BEAM-4524:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Nov/18 17:31
            Start Date: 16/Nov/18 17:31
    Worklog Time Spent: 10m 
      Work Description: swegner commented on issue #7049: [BEAM-4524] Use 
SHA256 for artifact validation
URL: https://github.com/apache/beam/pull/7049#issuecomment-439467852
 
 
   FYI, this regression caused Dataflow test jobs to hang indefinitely; I went 
into the GCP project and manually cancelled a bunch of jobs which were 
crash-looping on [this error](https://issues.apache.org/jira/browse/BEAM-6080) 
for nearly 24 hours.
   
   It seems like a small bug like this shouldn't be able to hang jobs 
indefinitely and eat up our GCP quotas. Are we missing some check to prevent 
indefinite crash-looping?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 166962)
    Time Spent: 4h 10m  (was: 4h)

> We should not be using md5 to validate artifact integrity.
> ----------------------------------------------------------
>
>                 Key: BEAM-4524
>                 URL: https://issues.apache.org/jira/browse/BEAM-4524
>             Project: Beam
>          Issue Type: Task
>          Components: beam-model
>            Reporter: Robert Bradshaw
>            Priority: Major
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> https://github.com/apache/beam/blob/6f239498e676f471427e17abc4bc5cffba9887c5/model/job-management/src/main/proto/beam_artifact_api.proto#L63
> Something like sha256 would probably be sufficient. 
> https://en.wikipedia.org/wiki/MD5#Overview_of_security_issues



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to