[
https://issues.apache.org/jira/browse/BEAM-4461?focusedWorklogId=167284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-167284
]
ASF GitHub Bot logged work on BEAM-4461:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/18 01:57
Start Date: 19/Nov/18 01:57
Worklog Time Spent: 10m
Work Description: reuvenlax commented on a change in pull request #6832:
[BEAM-4461] CoGroup transforms for schemas.
URL: https://github.com/apache/beam/pull/6832#discussion_r234476866
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java
##########
@@ -474,6 +493,29 @@ public boolean equals(Object o) {
&& Arrays.equals(getMetadata(), other.getMetadata());
}
+ /** Returns true if two FieldTypes are equal, ignoring name and
description. */
Review comment:
Confusing terminology - "TypeName" is the type, not the field name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 167284)
Time Spent: 18h 10m (was: 18h)
> Create a library of useful transforms that use schemas
> ------------------------------------------------------
>
> Key: BEAM-4461
> URL: https://issues.apache.org/jira/browse/BEAM-4461
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 18h 10m
> Remaining Estimate: 0h
>
> e.g. JoinBy(fields). Project, Filter, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
