[
https://issues.apache.org/jira/browse/BEAM-4444?focusedWorklogId=167585&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-167585
]
ASF GitHub Bot logged work on BEAM-4444:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/18 01:17
Start Date: 20/Nov/18 01:17
Worklog Time Spent: 10m
Work Description: udim commented on a change in pull request #6763:
[BEAM-4444] Parquet IO for Python SDK
URL: https://github.com/apache/beam/pull/6763#discussion_r234824416
##########
File path: sdks/python/apache_beam/io/parquetio_test.py
##########
@@ -293,6 +393,45 @@ def test_split_points(self):
]
assert len(splits) == 1
+ source_test_utils.assert_split_at_fraction_exhaustive(
+ splits[0].source, splits[0].start_position, splits[0].stop_position
+ )
+
+ def test_min_bundle_size(self):
+ file_name = self._write_data(count=120, row_group_size=20)
+
+ source = _create_parquet_source(file_name, min_bundle_size=100*1024*1024)
+ splits = [
+ split for split in source.split(desired_bundle_size=1)
+ ]
+ self.assertEquals(len(splits), 1)
+
+ source = _create_parquet_source(file_name, min_bundle_size=0)
+ splits = [
+ split for split in source.split(desired_bundle_size=1)
+ ]
+ self.assertNotEquals(len(splits), 1)
+
+ def test_failing_type_conversion(self):
+ file_name = self._write_data(
+ count=120, row_group_size=20, schema=self.SCHEMA96)
+ source = _create_parquet_source(file_name)
+ try:
+ # pylint: disable=unused-variable
+ import pandas
Review comment:
I'm not comfortable with this, as this test will silently stop working if
pandas is ever included as a Beam dependency in the future. Could you fail the
test if the import succeeds? Example:
```py
with self.assertRaises(ImportError):
import pandas
with self.assertRaises(ValueError):
source_test_utils.read_from_source(source)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 167585)
Time Spent: 10h 20m (was: 10h 10m)
> Parquet IO for Python SDK
> -------------------------
>
> Key: BEAM-4444
> URL: https://issues.apache.org/jira/browse/BEAM-4444
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Bruce Arctor
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> Add Parquet Support for the Python SDK.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
