[ https://issues.apache.org/jira/browse/BEAM-5197?focusedWorklogId=169614&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-169614 ]
ASF GitHub Bot logged work on BEAM-5197: ---------------------------------------- Author: ASF GitHub Bot Created on: 27/Nov/18 05:06 Start Date: 27/Nov/18 05:06 Worklog Time Spent: 10m Work Description: kennknowles closed pull request #7137: [BEAM-5197] Sickbay Flink UnboundedSourceWrapperTest.testWatermarkEmission() URL: https://github.com/apache/beam/pull/7137 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/UnboundedSourceWrapperTest.java b/runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/UnboundedSourceWrapperTest.java index 49945bf3a864..28589d52f628 100644 --- a/runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/UnboundedSourceWrapperTest.java +++ b/runners/flink/src/test/java/org/apache/beam/runners/flink/streaming/UnboundedSourceWrapperTest.java @@ -58,8 +58,8 @@ import org.apache.flink.util.InstantiationUtil; import org.apache.flink.util.OutputTag; import org.joda.time.Instant; +import org.junit.Ignore; import org.junit.Test; -import org.junit.experimental.runners.Enclosed; import org.junit.runner.RunWith; import org.junit.runners.JUnit4; import org.junit.runners.Parameterized; @@ -68,7 +68,6 @@ import org.slf4j.LoggerFactory; /** Tests for {@link UnboundedSourceWrapper}. */ -@RunWith(Enclosed.class) public class UnboundedSourceWrapperTest { private static final Logger LOG = LoggerFactory.getLogger(UnboundedSourceWrapperTest.class); @@ -103,7 +102,7 @@ public ParameterizedUnboundedSourceWrapperTest(int numTasks, int numSplits) { * Creates a {@link UnboundedSourceWrapper} that has one or multiple readers per source. If * numSplits > numTasks the source has one source will manage multiple readers. */ - @Test(timeout = 120_000) + @Test(timeout = 30_000) public void testValueEmission() throws Exception { final int numElementsPerShard = 20; FlinkPipelineOptions options = PipelineOptionsFactory.as(FlinkPipelineOptions.class); @@ -222,6 +221,7 @@ public void close() {} * <p>This test verifies that watermark are correctly forwarded. */ @Test(timeout = 30_000) + @Ignore("https://issues.apache.org/jira/browse/BEAM-5197") // deadlock on some platforms public void testWatermarkEmission() throws Exception { final int numElements = 500; final Object checkpointLock = new Object(); ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 169614) Time Spent: 2h 10m (was: 2h) > Flaky test: UnboundedSourceWrapperTest$ParameterizedUnboundedSourceWrapperTest > ------------------------------------------------------------------------------ > > Key: BEAM-5197 > URL: https://issues.apache.org/jira/browse/BEAM-5197 > Project: Beam > Issue Type: Improvement > Components: runner-flink > Reporter: Thomas Weise > Assignee: Kenneth Knowles > Priority: Critical > Labels: flake > Fix For: 2.10.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > {code:java} > java.lang.NullPointerException > at > org.apache.flink.streaming.runtime.tasks.TestProcessingTimeService$1.compare(TestProcessingTimeService.java:52) > at > org.apache.flink.streaming.runtime.tasks.TestProcessingTimeService$1.compare(TestProcessingTimeService.java:49) > at java.util.PriorityQueue.siftUpUsingComparator(PriorityQueue.java:670) > at java.util.PriorityQueue.siftUp(PriorityQueue.java:646) > at java.util.PriorityQueue.offer(PriorityQueue.java:345) > at > org.apache.flink.streaming.runtime.tasks.TestProcessingTimeService.registerTimer(TestProcessingTimeService.java:93) > at > org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.setNextWatermarkTimer(UnboundedSourceWrapper.java:452) > at > org.apache.beam.runners.flink.translation.wrappers.streaming.io.UnboundedSourceWrapper.run(UnboundedSourceWrapper.java:225) > at > org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:87) > at > org.apache.beam.runners.flink.streaming.UnboundedSourceWrapperTest$ParameterizedUnboundedSourceWrapperTest.testValueEmission(UnboundedSourceWrapperTest.java:153) > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)