[ 
https://issues.apache.org/jira/browse/BEAM-5850?focusedWorklogId=170887&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-170887
 ]

ASF GitHub Bot logged work on BEAM-5850:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Nov/18 23:55
            Start Date: 29/Nov/18 23:55
    Worklog Time Spent: 10m 
      Work Description: Ardagan commented on a change in pull request #6786: 
[BEAM-5850] Add QueueingBeamFnDataClient and make process, finish and start run 
on the same thread to support metrics.
URL: https://github.com/apache/beam/pull/6786#discussion_r237695449
 
 

 ##########
 File path: 
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
 ##########
 @@ -284,6 +304,11 @@ private void 
createRunnerAndConsumersForPTransformRecursively(
         startFunction.run();
       }
 
+      if (hasReadPTransform) {
 
 Review comment:
   This should not be needed. queueingClient should handle case with no read 
ptransforms fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 170887)

> Make process, finish and start run on the same thread to support metrics.
> -------------------------------------------------------------------------
>
>                 Key: BEAM-5850
>                 URL: https://issues.apache.org/jira/browse/BEAM-5850
>             Project: Beam
>          Issue Type: New Feature
>          Components: java-fn-execution
>            Reporter: Alex Amato
>            Assignee: Alex Amato
>            Priority: Major
>          Time Spent: 12h 40m
>  Remaining Estimate: 0h
>
> Update BeamFnDataReceiver to place elements into a Queue and consumer then 
> and call the element processing receiver in blockTillReadFinishes



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to