[
https://issues.apache.org/jira/browse/BEAM-5396?focusedWorklogId=171144&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-171144
]
ASF GitHub Bot logged work on BEAM-5396:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/18 17:51
Start Date: 30/Nov/18 17:51
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #7169:
[BEAM-5396] Savepoint restore option in Flink runner
URL: https://github.com/apache/beam/pull/7169#discussion_r237946939
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java
##########
@@ -138,11 +150,20 @@ static StreamExecutionEnvironment
createStreamExecutionEnvironment(
} else if (masterUrl.matches(".*:\\d*")) {
List<String> parts = Splitter.on(':').splitToList(masterUrl);
flinkConfig.setInteger(RestOptions.PORT, Integer.parseInt(parts.get(1)));
+
+ SavepointRestoreSettings savepointRestoreSettings =
SavepointRestoreSettings.none();
+ if (options.getSavepointPath() != null) {
+ savepointRestoreSettings =
+ SavepointRestoreSettings.forPath(
+ options.getSavepointPath(),
options.getAllowNonRestoredState());
+ }
Review comment:
It's probably more a matter of taste, I made the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 171144)
Time Spent: 1h 40m (was: 1.5h)
> Flink portable runner savepoint / upgrade support
> -------------------------------------------------
>
> Key: BEAM-5396
> URL: https://issues.apache.org/jira/browse/BEAM-5396
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Labels: portability, portability-flink
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The portable Flink runner needs to support Flink savepoints for production
> use. It should be possible to upgrade a stateful portable Beam pipeline that
> runs on Flink, which involves taking a savepoint and then starting the new
> version of the pipeline from that savepoint. The potential issues with
> pipeline evolution and migration are similar to those when using the Flink
> DataStream API (schema / name changes etc.).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
