[
https://issues.apache.org/jira/browse/BEAM-6160?focusedWorklogId=171698&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-171698
]
ASF GitHub Bot logged work on BEAM-6160:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/18 20:22
Start Date: 03/Dec/18 20:22
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #7168:
[BEAM-6160] Use service server rather than service
URL: https://github.com/apache/beam/pull/7168#discussion_r238420120
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/InProcessServerFactory.java
##########
@@ -40,21 +40,13 @@ public static InProcessServerFactory create() {
private InProcessServerFactory() {}
@Override
- public Server allocatePortAndCreate(BindableService service,
ApiServiceDescriptor.Builder builder)
- throws IOException {
+ public Server allocatePortAndCreate(
+ List<BindableService> services, ApiServiceDescriptor.Builder builder)
throws IOException {
String name = String.format("InProcessServer_%s",
serviceNameUniqifier.getAndIncrement());
builder.setUrl(name);
- return
InProcessServerBuilder.forName(name).addService(service).build().start();
- }
-
- @Override
- public Server create(BindableService service, ApiServiceDescriptor
serviceDescriptor)
- throws IOException {
- return InProcessServerBuilder.forName(serviceDescriptor.getUrl())
- .addService(
- ServerInterceptors.intercept(service,
GrpcContextHeaderAccessorProvider.interceptor()))
- .build()
- .start();
+ InProcessServerBuilder serverBuilder =
InProcessServerBuilder.forName(name);
+ services.stream().forEach(service -> serverBuilder.addService(service));
Review comment:
You need to add the GrpcContextHeaderAccessorProvider
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 171698)
Time Spent: 1h 40m (was: 1.5h)
> Simplify service and server creation in dataflow runner harness
> ---------------------------------------------------------------
>
> Key: BEAM-6160
> URL: https://issues.apache.org/jira/browse/BEAM-6160
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
