[ 
https://issues.apache.org/jira/browse/BEAM-5514?focusedWorklogId=171775&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-171775
 ]

ASF GitHub Bot logged work on BEAM-5514:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Dec/18 00:58
            Start Date: 04/Dec/18 00:58
    Worklog Time Spent: 10m 
      Work Description: ihji commented on a change in pull request #7189: 
[BEAM-5514] BigQueryIO doesn't handle quotaExceeded errors properly
URL: https://github.com/apache/beam/pull/7189#discussion_r238496363
 
 

 ##########
 File path: 
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServices.java
 ##########
 @@ -150,4 +156,47 @@ void createDataset(
     Table patchTableDescription(TableReference tableReference, @Nullable 
String tableDescription)
         throws IOException, InterruptedException;
   }
+
+  /** A class for controlling insertAll submission rate. */
 
 Review comment:
   added some comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 171775)
    Time Spent: 1h  (was: 50m)

> BigQueryIO doesn't handle quotaExceeded errors properly
> -------------------------------------------------------
>
>                 Key: BEAM-5514
>                 URL: https://issues.apache.org/jira/browse/BEAM-5514
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-gcp
>            Reporter: Kevin Peterson
>            Assignee: Heejong Lee
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> When exceeding a streaming quota for BigQuery insertAll requests, BigQuery 
> returns a 403 with reason "quotaExceeded".
> The current implementation of BigQueryIO does not consider this to be a rate 
> limited exception, and therefore does not perform exponential backoff 
> properly, leading to repeated calls to BQ.
> The actual error is in the 
> [ApiErrorExtractor|https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java#L739]
>  class, which is called from 
> [BigQueryServicesImpl|https://github.com/GoogleCloudPlatform/bigdata-interop/blob/master/util/src/main/java/com/google/cloud/hadoop/util/ApiErrorExtractor.java#L263]
>  to determine how to retry the failure.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to