[ 
https://issues.apache.org/jira/browse/BEAM-6094?focusedWorklogId=172250&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172250
 ]

ASF GitHub Bot logged work on BEAM-6094:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Dec/18 11:48
            Start Date: 05/Dec/18 11:48
    Worklog Time Spent: 10m 
      Work Description: robertwb commented on a change in pull request #7078: 
[BEAM-6094] Implement external environment for portable BeamPython.
URL: https://github.com/apache/beam/pull/7078#discussion_r239032814
 
 

 ##########
 File path: 
sdks/python/apache_beam/runners/portability/local_job_service_main.py
 ##########
 @@ -32,10 +32,8 @@ def run(argv):
   parser.add_argument('-p', '--port',
                       type=int,
                       help='port on which to serve the job api')
-  parser.add_argument('--worker_command_line',
-                      help='command line for starting up a worker process')
   options = parser.parse_args(argv)
-  job_servicer = 
local_job_service.LocalJobServicer(options.worker_command_line)
+  job_servicer = local_job_service.LocalJobServicer()
 
 Review comment:
   No, this is now passed via an environment rather than out-of-band.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 172250)
    Time Spent: 1h 50m  (was: 1h 40m)

> Implement External environment for Portable Beam
> ------------------------------------------------
>
>                 Key: BEAM-6094
>                 URL: https://issues.apache.org/jira/browse/BEAM-6094
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-model
>            Reporter: Robert Bradshaw
>            Assignee: Robert Bradshaw
>            Priority: Major
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to