[
https://issues.apache.org/jira/browse/BEAM-6182?focusedWorklogId=172416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-172416
]
ASF GitHub Bot logged work on BEAM-6182:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/18 17:48
Start Date: 05/Dec/18 17:48
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #7203:
[BEAM-6182] Disable conscrypt by default
URL: https://github.com/apache/beam/pull/7203#discussion_r239169766
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/DataflowWorkerHarnessHelper.java
##########
@@ -57,18 +57,19 @@ public static DataflowWorkerHarnessOptions
initializeGlobalStateAndPipelineOptio
ExperimentContext ec = ExperimentContext.parseFrom(pipelineOptions);
- String experimentName =
Experiment.DisableConscryptSecurityProvider.getName();
- if (!ec.isEnabled(Experiment.DisableConscryptSecurityProvider)) {
+ String experimentName =
Experiment.EnableConscryptSecurityProvider.getName();
+ if (ec.isEnabled(Experiment.EnableConscryptSecurityProvider)) {
Review comment:
1. We have a sense that IO bound pipelines could be affected up-to a 15%.
(The number mentioned from the previous PR.) Likely typical regression will be
much less.
2. This does not affect Beam in general. It affects Dataflow only. I think
highlighting this in the release notes is a good idea. (Dataflow if they choose
to do so could take additional proactive measures to communicate the change.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 172416)
Time Spent: 0.5h (was: 20m)
> Use of conscrypt SSL results in stuck workflows in Dataflow
> -----------------------------------------------------------
>
> Key: BEAM-6182
> URL: https://issues.apache.org/jira/browse/BEAM-6182
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Ahmet Altay
> Assignee: Tyler Akidau
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> An experimental flag is being added to disable it for now with an option to
> enable it per-workflow.
> Also related:
> https://issues.apache.org/jira/browse/BEAM-5747 - Upgrade conscrypt to its
> latest version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
